public/wikipedia-module-citeq
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix too many item lookups on items will silly amounts of authors

Browse source
This commit is contained in:
Jonathan Harker 2026-10-05 21:42:08 +13:00
parent 43bf989f91
commit b2ab54ccb4
1 changed files with 19 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

23
module_citeq.lua
View file

@ -107,6 +107,8 @@ end
-- function to fetch a value to display -- function to fetch a value to display
local function makelink(v, out, link, maxpos, wdl, namestyle) local function makelink(v, out, link, maxpos, wdl, namestyle)
local label local label
local max_authors_displayed = 10 -- TODO: this is probably in CS1 config somewhere
local item_lookup = false
if v.mainsnak.snaktype == "value" then if v.mainsnak.snaktype == "value" then
if v.mainsnak.datatype == "wikibase-item" then if v.mainsnak.datatype == "wikibase-item" then
local qnumber = v.mainsnak.datavalue.value.id local qnumber = v.mainsnak.datavalue.value.id
@ -123,12 +125,15 @@ local function makelink(v, out, link, maxpos, wdl, namestyle)
first_names = v.qualifiers.P9687[1].datavalue.value first_names = v.qualifiers.P9687[1].datavalue.value
end end
-- Otherwise, get last name, first name(s) from author item properties -- Otherwise, get last name, first name(s) from author item properties
last_name = last_name or getValue({"P734", qid=qnumber, maxvals=1, ps=2}) -- but this requires a getValue WD item lookup for each author, and
first_names = first_names or getValue({"P735", qid=qnumber, maxvals=0, ps=2}) -- lookups are limited to 500 per page, so do this after we have the
if first_names then -- "series ordinal" order, then only do the first few since there are
first_names = getStyledNames(first_names, namestyle) -- article items out there with 400+ authors(!)
if not last_name or not first_names then
item_lookup = true
end end
-- use object named as for the label
if v.qualifiers and v.qualifiers.P1932 then if v.qualifiers and v.qualifiers.P1932 then
label = v.qualifiers.P1932[1].datavalue.value -- "object named as" label = v.qualifiers.P1932[1].datavalue.value -- "object named as"
else else
@ -145,6 +150,16 @@ local function makelink(v, out, link, maxpos, wdl, namestyle)
position = tonumber(v.qualifiers.P1545[1].datavalue.value) position = tonumber(v.qualifiers.P1545[1].datavalue.value)
end end
maxpos = math.max(maxpos, position) maxpos = math.max(maxpos, position)
-- now try determining first/last names with item lookup, if needed
if item_lookup and position <= max_authors_displayed then
last_name = last_name or getValue({"P734", qid=qnumber, maxvals=1, ps=2})
first_names = first_names or getValue({"P735", qid=qnumber, maxvals=0, ps=2})
end
if first_names then
first_names = getStyledNames(first_names, namestyle)
end
if sitelink then if sitelink then
-- just the plain name, -- just the plain name,
-- but keep a record of the links, using the same index -- but keep a record of the links, using the same index